Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use gRPC query ConnectionParams instead of /genesis to verify max_block_time #4144

Merged
merged 5 commits into from
Aug 14, 2024
Merged

Use gRPC query ConnectionParams instead of /genesis to verify max_block_time #4144

merged 5 commits into from
Aug 14, 2024

Conversation

ljoss17
Copy link
Contributor

@ljoss17 ljoss17 commented Aug 13, 2024

Closes: #4143

Description

PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@ljoss17 ljoss17 requested review from romac and ancazamfir August 13, 2024 15:14
ancazamfir
ancazamfir requested changes Aug 13, 2024
View reviewed changes
crates/relayer/src/chain/cosmos.rs Outdated Show resolved Hide resolved
crates/relayer/src/chain/cosmos.rs Outdated Show resolved Hide resolved
crates/relayer/src/chain/cosmos.rs Outdated Show resolved Hide resolved
crates/relayer/src/chain/cosmos.rs Show resolved Hide resolved
@ancazamfir
Copy link
Collaborator

soo happy to see the genesis endpoint going away!! thanks @ljoss17 !!

ljoss17 and others added 3 commits August 14, 2024 08:36
@ljoss17 @romac @ancazamfir
Apply suggestions from code review
79728af 
Co-authored-by: Romain Ruetschi <romain@informal.systems>
Co-authored-by: Anca Zamfir <ancazamfir@users.noreply.github.com>
Signed-off-by: Luca Joss <43531661+ljoss17@users.noreply.github.com>
@ljoss17
Override configured if it differs from queried value
ae81050
@ljoss17
Add debug log with queried value for 'max_expected_time_per_block'
7d736c0
@ljoss17 ljoss17 mentioned this pull request Aug 14, 2024
Open
5 tasks
ancazamfir
ancazamfir approved these changes Aug 14, 2024
View reviewed changes
Copy link
Collaborator

@ancazamfir ancazamfir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @ljoss17 ! 🚀

@ljoss17 ljoss17 added this pull request to the merge queue Aug 14, 2024
Merged via the queue into master with commit f69a6d7 Aug 14, 2024
29 checks passed
@ljoss17 ljoss17 deleted the luca_joss/directly-query-max-time-per-block branch August 14, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romac romac romac left review comments

@ancazamfir ancazamfir ancazamfir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use gRPC query ConnectionParams instead of /genesis to verify max_block_time
3 participants
@ljoss17 @ancazamfir @romac